Rework inline play behaviour #13023
Merged
Rework inline play behaviour #13023
+39
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
|
Size Change: +3 B (0%) Total Size: 942 kB ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
Georges-GNM
approved these changes
Dec 18, 2024
Georges-GNM
reviewed
Dec 18, 2024
| @@ -20,7 +20,7 @@ const cardProps: CardProps = { | |||
| }, | |||
| imagePositionOnDesktop: 'top', | |||
| isExternalLink: false, | |||
| isPlayableMediaCard: false, | |||
| canPlayInline: true, | |||
There was a problem hiding this comment.
It's just a story so not super important, but was this meant to be changed to true?
There was a problem hiding this comment.
yep, feature cards should play inline 👍
|
Seen on PROD (merged by @abeddow91 8 minutes and 47 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Renames
isPlayableMediaCard->canPlayInlineand sets the value of this on beta containers.Why?
Editorial can decide what stories have a video displaying on the front. However, design do not want cards that are smaller than 300px to play inline which is the size at which the youtube player stops showing controls . This prop controls video playback functionality at the card level.